Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix work-around for mirrors when only the names need to be preserved #15613

Closed
floitschG opened this issue Dec 12, 2013 · 3 comments
Closed

Fix work-around for mirrors when only the names need to be preserved #15613

floitschG opened this issue Dec 12, 2013 · 3 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@floitschG
Copy link
Contributor

We currently have a work-around in dart2js so that classes that have names that need to be preserved, but don't use other reflection don't generate bad code (see issue #15602).

When reifying type variables we now simply discard the information and return 0.
@peter-ahe-google
Copy link
Contributor

Added Library-Mirrors label.

@floitschG
Copy link
Contributor Author

Different work-around: we use quotes around the "Placeholder for ..." string.
This way the generated code is correct.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Mar 3, 2018
@matanlurey
Copy link
Contributor

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @matanlurey @peter-ahe-google @floitschG