Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MirrorsUsed cannot merge symbols #15599

Closed
blois opened this issue Dec 12, 2013 · 4 comments
Closed

MirrorsUsed cannot merge symbols #15599

blois opened this issue Dec 12, 2013 · 4 comments
Assignees
@peter-ahe-google
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@blois
Copy link
Contributor

blois commented Dec 12, 2013

Given a library which imports dart:mirrors with:

library a;
@MirrorsUsed(symbols: ['foo'])
import 'dart:mirrors';

Then another import which attempts to modify the first with:
@MirrorsUsed(symbols: const ['bar'], override: 'a')
import 'dart:mirrors';

The dart2js compiler fails with:

Internal error: Unsupported operation: Cannot add to a non-extendable array

­0 List.addAll (dart:core-patch/array.dart:230)

­1 MirrorUsageAnalyzer.merge (file:///mnt/data/b/build/slave/dart-editor-linux-stable/build/dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart:311)

­2 MirrorUsageAnalyzer.mergeUsages (file:///mnt/data/b/build/slave/dart-editor-linux-stable/build/dart/sdk/lib/_internal/compiler/implementation/mirrors_used.dart:289)
@peter-ahe-google
Copy link
Contributor

https://codereview.chromium.org/113283008

Set owner to @peter-ahe-google.
Added Started label.

@peter-ahe-google
Copy link
Contributor

Issue #15919 has been merged into this issue.

cc @floitschG.

@srawlins
Copy link
Member

https://codereview.chromium.org/113283008 was submitted. Can this be closed?

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Mar 3, 2018
@matanlurey
Copy link
Contributor

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @srawlins @matanlurey @blois @peter-ahe-google