Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub build produces a huge amount of output that seems redundant #15509

Closed
DartBot opened this issue Dec 7, 2013 · 9 comments
Closed

pub build produces a huge amount of output that seems redundant #15509

DartBot opened this issue Dec 7, 2013 · 9 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-dart2js

Comments

@DartBot
Copy link

DartBot commented Dec 7, 2013

This issue was originally filed by @zoechi


What steps will reproduce the problem?
1.
run pub build on a polymer project

2.
I had the following messages already before the last updates (since pub build is usable).

Building polymer_elements_examples...........
[Warning in Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/path/path.dart:49:23: Hint: Can't find 'dart.io.Directory.current' in the current library.
Did you forget to add an import?
@MirrorsUsed(targets: 'dart.dom.html.window, '
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
[Warning in Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/path/path.dart:49:23: Hint: Can't find 'dart.io.Platform.operatingSystem' in the current library.
Did you forget to add an import?
@MirrorsUsed(targets: 'dart.dom.html.window, '
                      ^^^^^^^^^^^^^^^^^^^^^^^^^

[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/polymer/polymer.dart:50:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/observe/src/observable.dart:16:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/observe/src/path_observer.dart:10:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/path/path.dart:52:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/polymer_expressions/eval.dart:12:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/polymer_expressions/src/mirrors.dart:11:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/polymer/deserialize.dart:8:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors' show TypeMirror;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
packages/polymer/src/reflected_type.dart:11:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^

These are new

[Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
../../../3rdparty/google/darteditor/dart-sdk/lib/html/dart2js/html_dart2js.dart:26708:1: Warning: 'Window' doesn't implement 'clearInterval'.
Try adding an implementation of 'clearInterval'.
class Window extends EventTarget implements WindowBase, _WindowTimers, WindowBase64 native "Window,DOMWindow" {
^^^^^
[Warning in Dart2JS on polymer_elements_examples|web/polymer_file.dart]:
../../../3rdparty/google/darteditor/dart-sdk/lib/html/dart2js/html_dart2js.dart:30378:8: Info: This is the method declaration.
  void clearInterval(int handle);
       ^^^^^^^^^^^^^

similar with

  • clearTimeout
  • setInterval
  • setTimeout
  • addAll

instead of clearInterval

These are the one where I'm sure I have something to do.

[Warning in Dart2JS on polymer_elements_examples|web/polymer_selector.html_bootstrap.dart]:
packages/polymer/src/instance.dart:388:31: Hint: Using 'MirrorSystem.getName' may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
      attributes[MirrorSystem.getName(name)] = serializedValue;

3.

What is the expected output? What do you see instead?
Only relevant messages should be logged.

What version of the product are you using? On what operating system?
Dart VM version: 1.0.3.0_r30939 (Fri Dec 6 03:48:53 2013) on "linux_x64"

Please provide any additional information below.
This is a project with about 20 simple pages each using a few polymer elements.

pub build produces 1700+ lines of output.

This huge amount of output is horrible and I don't know if I can do something to fix it.
Some clarification is very much appreciated.

Thanks
Günter

@sgjesse
Copy link
Contributor

sgjesse commented Dec 9, 2013

Added Area-Polymer, Triaged labels.

@sigmundch
Copy link
Member

The first two messages from the path package seem to be fixed in the repo and we just need to update dependencies to use the latest version of 'path'.

I'm reassigning the area to Dart2js as most of the messages are 'hints' from Dart2js from uses of dart:mirrors that already have a @­MirrorUsed annotation.


Removed Area-Polymer label.
Added Area-Dart2JS label.

@DartBot
Copy link
Author

DartBot commented Dec 29, 2013

This comment was originally written by carlj...@gmail.com


Is there a temporary fix one can do to get past this?

@DartBot
Copy link
Author

DartBot commented Dec 30, 2013

This comment was originally written by vladimir.matusev...@gmail.com


I have the same issue with latest Dart Editor in project that using polymer.

@floitschG
Copy link
Contributor

We have improved our error-reporting.

Is this still a problem?


Added NeedsInfo label.

@DartBot
Copy link
Author

DartBot commented May 21, 2014

This comment was originally written by garrick.blackberr...@gmail.com


I wouldn't describe the output as a problem anymore. Not for me. I do wonder why methods retained by dart:mirrors is a warning and not information.
([Warning from Dart2JS]:
web/system/login.html_bootstrap.dart:
716 methods retained for use by dart:mirrors out of 3065 total methods (23%).)
I have not imported mirrors directly as part of my work so I always ignore the warning.
It's something I just have to accept.
If those warnings were Info instead then any warnings I have to take care of would be much more obvious.

@peter-ahe-google
Copy link
Contributor

As far as dart2js is concerned, the message is a "hint" not a "warning".

@floitschG
Copy link
Contributor

cc @johnniwinther.

@DartBot
Copy link
Author

DartBot commented Feb 2, 2015

This comment was originally written by @zoechi


Added AssumedStale label.

@DartBot DartBot added Type-Defect web-dart2js closed-obsolete Closed as the reported issue is no longer relevant labels Feb 2, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-dart2js
Projects
None yet
Development

No branches or pull requests

6 participants