Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart-sdk executables should work through more than one symlink redirection #15486

Open
kevmoo opened this issue Dec 6, 2013 · 2 comments
Open

dart-sdk executables should work through more than one symlink redirection #15486

kevmoo opened this issue Dec 6, 2013 · 2 comments
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kevmoo
Copy link
Member

kevmoo commented Dec 6, 2013

Related to r30287, https://code.google.com/p/dart/issues/detail?id=9409

As an example, homebrew on mac creates a couple levels of symlinks

working: dart
not working: dart2js, dartanalyzer, dartdoc, pub

r30821
@nex3
Copy link
Member

nex3 commented Dec 6, 2013

Are you referring to symlinks to the files themselves or to the directories? What platforms have you tested this on? Can you give an example of a reproduction case?

I've tested this on Ubuntu with symlinks to both the files themselves and to the directories and it works. Are you sure you've rebuilt your SDK recently?

@kevmoo
Copy link
Member Author

kevmoo commented Dec 6, 2013

I'm working off the dev build r30821

I have the changes as of r30287.

This case fails with the shipping code, but works with the patch I submitted:

  1. [...]/dart-sdk/bin/dartdoc
  2. [homebrew]/bin/dartdoc -> #­1
  3. /urs/local/bin/dartdoc -> #­2

Patch: https://codereview.chromium.org/98353004/

Added Started label.

@kevmoo kevmoo added Type-Defect area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). labels Dec 6, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @kevmoo