Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile-time regression after landing check for unimplemented methods #15462

Closed
peter-ahe-google opened this issue Dec 5, 2013 · 2 comments
Closed

Compile-time regression after landing check for unimplemented methods #15462

peter-ahe-google opened this issue Dec 5, 2013 · 2 comments
Assignees
@johnniwinther
Labels
web-dart2js

Comments

@peter-ahe-google
Copy link
Contributor

The checks implemented in r30859 are too slow. Shows 5% compile-time regression on swarm.
@peter-ahe-google
Copy link
Contributor Author

Johnni is already planning a major rewrite of how we compute information about supertypes, and volunteered to fix this issue.

Set owner to @johnniwinther.
Added Accepted label.

@johnniwinther
Copy link
Member

Optimizations have be implemented but we (need to) do more work than before the regression is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @peter-ahe-google @johnniwinther