Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues with samples #15337

Closed
kwalrath opened this issue Nov 26, 2013 · 2 comments
Closed

issues with samples #15337

kwalrath opened this issue Nov 26, 2013 · 2 comments
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Nov 26, 2013 •
edited by srawlins

  1. Under "Searching files for content"
    it should say "files and directories" not "file and directories".

    That is, make "file" plural.

  2. The Try It links for "working with JSON" and "fetching data dynamically" link into the tutorial. These should link to READMEs with the deployed apps instead.

  3. The Try It page for the requestAnimationFrame sample displays a warning in the console:

    The page at https://www.dartlang.org/samples/raf/ displayed insecure content from http://1-ps.googleusercontent.com/x/s.html5rocks-hrd.appspot.com/www.html5r…com/en/tutorials/speed/animations/particle.png.pagespeed.ce.jWkhaHzlBa.png.

  4. The Geolocation sample has an exception, with a stack trace:

    Uncaught Error: NullError: Cannot call "get$coords" on null 
collection_dev_patch.dart:21
Stack Trace: 
TypeError: Cannot call method 'get$coords' of null
at Object.J.get$coords$x (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:5920:39)
at main_closure1.call$1 (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:5720:55)
at Object.rootRunUnary (https://www.dartlang.org/samples/geolocation/example/tripmeter.dart.js:2660:14)
at RootZone.runUnary$2 (https://www.dartlang.org/samples/geolocation/example/tripmeter.dart.js:3772:14)
at RootZone.BaseZone.runUnaryGuarded$2 (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:3702:17)
at ControllerSubscription.BufferingStreamSubscription.sendData$1 (https://www.dartlang.org/samples/geolocation/example/tripmeter.dart.js:3516:16)
at ControllerSubscription.BufferingStreamSubscription.async$add$1 (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:3473:12)
at SyncStreamControllerDispatch.sendData$1 (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:3307:30)
at SyncStreamController.StreamController.async$add$1 (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:3253:12)
at Geolocation_watchPosition__closure.call$1 (https://www.dartlang.org/samples/geolocation/example/trip_meter.dart.js:5441:8)
collection_dev_patch.dart:21
Uncaught NullError: Cannot call "get$coords" on null js_helper.dart:834
@DartBot
Copy link

DartBot commented Oct 14, 2014

This comment was originally written by shaile...@google.com

Set owner to @nicolasgarnier.

@kwalrath kwalrath added Type-Defect area-samples (deprecated) Deprecated: this label is no longer actively used. labels Oct 14, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

I don't think these pages exist any more. The site has been redesigned a few times since this was opened. Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @srawlins @kwalrath @nicolasgarnier @DartBot