Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report which import of dart:mirrors does not have MirrorsUsed #14839

Closed
sethladd opened this issue Nov 5, 2013 · 8 comments
Closed

Report which import of dart:mirrors does not have MirrorsUsed #14839

sethladd opened this issue Nov 5, 2013 · 8 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@sethladd
Copy link
Contributor

sethladd commented Nov 5, 2013

Output today:

packages/serialization/src/mirrors_helpers.dart:12:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';

If dart2js -v could tell me, in obvious terms, that a particular import of mirrors didn't specify MirrorsUsed, I can then better track down the culprit.

@sethladd
Copy link
Contributor Author

Peter, any ideas on the difficulty of this request?


cc @peter-ahe-google.

@peter-ahe-google
Copy link
Contributor

@peter-ahe-google
Copy link
Contributor

Set owner to @peter-ahe-google.

@sethladd
Copy link
Contributor Author

Thanks Peter! Since there are many combinations of targets, meta, etc what about saying something like:

This import does not include @­MirrorsUsed, which may lead to unnecessarily large generated code. Please see http://api.dartlang.org/docs/channels/stable/latest/dart_mirrors/MirrorsUsed.html for instructions.

Or, use this: http://goo.gl/kqqUNX


cc @kwalrath.
cc @lukechurch.

@kwalrath
Copy link
Contributor

I'd make the link to http://api.dartlang.org/dart_mirrors/MirrorsUsed.html. (Or use a goo.gl link if the direct one is too long.)

@kwalrath
Copy link
Contributor

Oh, and don't say "Please". :)

@peter-ahe-google
Copy link
Contributor

Thank you for the great suggestions. I'll use https://goo.gl/Akrrog (which is short for https://api.dartlang.org/dart_mirrors/MirrorsUsed.html).

@sigmundch
Copy link
Member

dart2js now reports where the imports to mirrors come from. It doesn't highlight which ones are missing the annotation, but it should narrow it down quickly for our users.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Development

No branches or pull requests

5 participants