New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report which import of dart:mirrors does not have MirrorsUsed #14839
Comments
Peter, any ideas on the difficulty of this request? |
https://codereview.chromium.org/78223004/ Added Started label. |
Set owner to @peter-ahe-google. |
Thanks Peter! Since there are many combinations of targets, meta, etc what about saying something like: This import does not include @MirrorsUsed, which may lead to unnecessarily large generated code. Please see http://api.dartlang.org/docs/channels/stable/latest/dart_mirrors/MirrorsUsed.html for instructions. Or, use this: http://goo.gl/kqqUNX cc @kwalrath. |
I'd make the link to http://api.dartlang.org/dart_mirrors/MirrorsUsed.html. (Or use a goo.gl link if the direct one is too long.) |
Oh, and don't say "Please". :) |
Thank you for the great suggestions. I'll use https://goo.gl/Akrrog (which is short for https://api.dartlang.org/dart_mirrors/MirrorsUsed.html). |
dart2js now reports where the imports to mirrors come from. It doesn't highlight which ones are missing the annotation, but it should narrow it down quickly for our users. |
Output today:
packages/serialization/src/mirrors_helpers.dart:12:1: Info: Import of 'dart:mirrors'.
import 'dart:mirrors';
If dart2js -v could tell me, in obvious terms, that a particular import of mirrors didn't specify MirrorsUsed, I can then better track down the culprit.
The text was updated successfully, but these errors were encountered: