Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No hint or warning if parted file is not specified as part in library #14743

Closed
sethladd opened this issue Nov 2, 2013 · 5 comments
Closed
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

sethladd commented Nov 2, 2013

Consider this code:

part of wordherd_shared;

class GameSolo extends Object with Persistable {
  @­serialized Board board;
  @­serialized Game game;
  DateTime created_at; // set by persistance
  DateTime updated_at;
}

and the library:

library wordherd_shared;

import 'dart:collection' show LinkedHashMap;
import 'package:observe/observe.dart';
import 'dart:math';
import 'persistable_html.dart';

part 'src/shared/game.dart';
part 'src/shared/board.dart';
part 'src/shared/game_match.dart';
part 'src/shared/boards.dart';
part 'src/shared/game_constants.dart';
part 'src/shared/player.dart';

I don't see a hint or warning that the library doesn't actually specify GameSolo as a part.


Attachment:
[Screen Shot 2013-11-02 at 2.12.33 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-14743/comment-0/Screen Shot 2013-11-02 at 2.12.33 PM.png) (23.67 KB)

@clayberg
Copy link

clayberg commented Nov 3, 2013

Set owner to @jwren.
Added this to the Later milestone.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Medium labels.

@jwren
Copy link
Member

jwren commented Nov 4, 2013

Removed Area-Editor label.
Added Area-Analyzer label.

@clayberg
Copy link

clayberg commented Apr 1, 2014

Added Analyzer-Hint label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sethladd sethladd added Type-Enhancement area-analyzer analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@jwren jwren removed their assignment Oct 6, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@lrhn lrhn added the closed-obsolete Closed as the reported issue is no longer relevant label May 9, 2023
@lrhn lrhn closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants