Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization uses mirrors without MirrorsUsed #14741

Closed
sethladd opened this issue Nov 2, 2013 · 7 comments
Closed

Serialization uses mirrors without MirrorsUsed #14741

sethladd opened this issue Nov 2, 2013 · 7 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-invalid Closed as we don't believe the reported issue is generally actionable type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

sethladd commented Nov 2, 2013

We should use MirrorsUsed with Serialization, because it uses mirrors for the default serialization mechanism.

Perhaps metaTargets and a @­serializable annotation that I can put on my classes.

@sethladd
Copy link
Contributor Author

sethladd commented Nov 2, 2013

cc @alan-knight.

@alan-knight
Copy link
Contributor

Set owner to @alan-knight.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.

@sethladd
Copy link
Contributor Author

Meanwhile, you can use something like this in your app:

// Turn on mirrors used for serialization
@MirrorsUsed(targets: const ['my_library_that_I_serialize', 'serialization'],
             override: 'mirrors_helpers')
import 'dart:mirrors';

NOTE: you must also add serialization (as shown above) to the list of targets.

@alan-knight
Copy link
Contributor

Issue #15344 has been merged into this issue.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@nicolasgarnier
Copy link
Contributor

Please file in the GitHub package directly at: https://github.com/google/serialization.dart/issues

(this is part of a manual cleanup as we are migrating the issue tracker to GitHub)


Added Invalid label.

@sethladd sethladd added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-invalid Closed as we don't believe the reported issue is generally actionable labels May 21, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-invalid Closed as we don't believe the reported issue is generally actionable type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants