Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/mock should integrate with Invocation/Symbol #14725

Closed
DartBot opened this issue Nov 1, 2013 · 6 comments
Closed

pkg/mock should integrate with Invocation/Symbol #14725

DartBot opened this issue Nov 1, 2013 · 6 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Nov 1, 2013

This issue was originally filed by @seaneagan


In LogEntry:

String methodName;
List arguments;

should be replaced with

Invocation invocation;

And the CallMatcher concept should be replaced with true Matchers against Invocations.

That way named arguments are supported, and less concepts and API surface are needed.

Then callsTo could support a Symbol as the member name, and could be implemented itself with noSuchMethod, allowing to use named arguments as well:

callsTo(#foo, new isInstanceOf<String>(), someNamedArg: isNotNull);

which would match calls like:

mock.foo('a String', someNamedArg: notNull);

@dgrove
Copy link
Contributor

dgrove commented Nov 6, 2013

Added Area-UnitTest, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Nov 15, 2013

This comment was originally written by cvl.c...@gmail.com


I'm stuck with my unittesting to the point, where I have to check the named arguments passed to a mock.
I can't find a workaround, so I hope this issue is gonna be addressed soon.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg, Pkg-Unittest labels.

@kevmoo
Copy link
Member

kevmoo commented May 9, 2014

Removed Pkg-Unittest label.
Added Pkg-mock label.

@kevmoo
Copy link
Member

kevmoo commented May 9, 2014

Removed Type-Defect label.
Added Type-Enhancement label.
Changed the title to: "pkg/mock should integrate with Invocation/Symbol".

@DartBot DartBot added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels May 9, 2014
@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

This issue has been moved to dart-archive/mock#2.

@DartBot DartBot closed this as completed Jun 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants