Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/mock should rely on method cascades #14715

Closed
DartBot opened this issue Nov 1, 2013 · 6 comments
Closed

pkg/mock should rely on method cascades #14715

DartBot opened this issue Nov 1, 2013 · 6 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Nov 1, 2013

This issue was originally filed by @seaneagan

Behavior.* and LogEntryList.verify currently return this for chaining. They should instead be void, and method cascades should be used by users of the APIs. See issue #14714.
@DartBot
Copy link
Author

DartBot commented Nov 1, 2013

This comment was originally written by @seaneagan

Sorry, it's actually in 'package:unittest/mock.dart'.

@dgrove
Copy link
Contributor

dgrove commented Nov 6, 2013

Added Area-UnitTest, Triaged labels.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg, Pkg-Unittest labels.

@kevmoo
Copy link
Member

kevmoo commented May 9, 2014

Removed Pkg-Unittest label.
Added Pkg-mock label.

@kevmoo
Copy link
Member

kevmoo commented May 9, 2014

Removed Type-Defect label.
Added Type-Enhancement label.
Changed the title to: "pkg/mock should rely on method cascades".

@DartBot DartBot added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels May 9, 2014
@DartBot DartBot mentioned this issue Jun 4, 2015
Open
@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

This issue has been moved to dart-archive/mock#1.

@DartBot DartBot closed this as completed Jun 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @dgrove @DartBot