Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/mirrors/library_metadata2_test.dart should specify compile-time error #14682

Open
scheglov opened this issue Oct 31, 2013 · 4 comments
Open

lib/mirrors/library_metadata2_test.dart should specify compile-time error #14682

scheglov opened this issue Oct 31, 2013 · 4 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@scheglov
Copy link
Contributor

From specification:

It is a compile time error if the expression is not one of the following:
 - A reference to a compile-time constant variable.
 - The name of a class.
 - A call to a constant constructor.

  I don't understand why it was changed in https://codereview.chromium.org/24789003/

  Analyzer (will) reports compile-time error and tests runner does not understand specifying both (or I don't know how to do this).
@crelier
Copy link
Contributor

crelier commented Oct 31, 2013

There was a long discussion about this metadata issue between Peter, Gilad, and Ivan. I am not sure if there was a definitive resolution, though.
Reassigning to Ivan.

Set owner to @iposva-google.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@scheglov scheglov added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 4, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@iposva-google iposva-google removed their assignment May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @scheglov @kasperl @iposva-google @crelier