Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dartium tests should respect VMOptions from test files #14651

Closed
fsc8000 opened this issue Oct 31, 2013 · 4 comments
Closed

Dartium tests should respect VMOptions from test files #14651

fsc8000 opened this issue Oct 31, 2013 · 4 comments
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@fsc8000
Copy link
Contributor

fsc8000 commented Oct 31, 2013

Certain tests require the correct options to be passed to the VM to pass. Dartium needs to pass these on to Dart VM when running Dartium tests.

One example is language/issue13474_test.
@ricowind
Copy link
Contributor

cc @mkustermann.
Removed the owner.

@blois
Copy link
Contributor

blois commented Oct 31, 2013

Issue #14689 has been merged into this issue.

@mkustermann
Copy link
Member

Removed Area-Test label.
Added Area-Infrastructure label.

@fsc8000 fsc8000 added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Nov 23, 2013
@mkustermann mkustermann mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@whesse
Copy link
Member

whesse commented Oct 3, 2016

Because we use a pool of open Dartium browsers to run all the dartium tests, we don't have a separate browser instance for each test. Therefore we can't pass separate dart VM options to dartium for each test. Since Dartium is heading for deprecation, I don't think this is worth fixing.

@whesse whesse closed this as completed Oct 3, 2016
@johnmccutchan johnmccutchan mentioned this issue Feb 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @blois @fsc8000 @whesse @ricowind @mkustermann