Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DartObject from the global JS namespace, remove interop.js #14627

Open
justinfagnani opened this issue Oct 30, 2013 · 2 comments
Open

Remove DartObject from the global JS namespace, remove interop.js #14627

justinfagnani opened this issue Oct 30, 2013 · 2 comments
Assignees
@justinfagnani
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-js P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-js-interop Issues that impact all js interop

Comments

@justinfagnani
Copy link
Contributor

DartObject pollutes the JavaScript namespace and creates a single proxy class for all Dart objects regardless of the isolate they originate from, potentially allowing Dart object to leak across isolates.

If we emit a DartObject function/prototype directly from dart2js it'll be accessible from dart:js without being in the global namespace.
@sethladd
Copy link
Contributor

Do we still intend to do this?

@justinfagnani justinfagnani added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-js labels Jul 24, 2014
@justinfagnani justinfagnani self-assigned this Jul 24, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
@sigmundch sigmundch added the web-js-interop Issues that impact all js interop label Nov 8, 2021
@sigmundch
Copy link
Member

needs another look, but this is likely obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinfagnani justinfagnani

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-js P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-js-interop Issues that impact all js interop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @justinfagnani @sigmundch @vsmenon