Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Tip/Hint if import statement does not have a show/hide or as #14581

Closed
sethladd opened this issue Oct 29, 2013 · 6 comments
Closed

Add a Tip/Hint if import statement does not have a show/hide or as #14581

sethladd opened this issue Oct 29, 2013 · 6 comments
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

It's best to use a show/hide or prefix when using an import. The analyzer could display a tip/hint if it encounters an import without a show/hide or prefix.
@bwilkerson
Copy link
Member

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@clayberg
Copy link

clayberg commented Apr 1, 2014

Added Analyzer-Hint label.

@munificent
Copy link
Member

It's best to use a show/hide or prefix when using an import.

Have we reached consensus on that? Documented it anywhere?

The last time I looked at the Dart code in the wild, something like 90% of it did not do this.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sethladd sethladd added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

Yeah I think this can be closed. Most code doesn't adhere to this. It could be a https://github.com/dart-lang/linter lint.

@bwilkerson bwilkerson added analyzer-linter Issues with the analyzer's support for the linter package and removed analyzer-warning Issues with the analyzer's Warning codes labels Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sethladd @kevmoo @munificent @srawlins @kasperl @bwilkerson @clayberg