Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-tests should report tests that run slow #14531

Closed
iposva-google opened this issue Oct 28, 2013 · 4 comments
Closed

Unit-tests should report tests that run slow #14531

iposva-google opened this issue Oct 28, 2013 · 4 comments
Labels

Comments

@iposva-google
Copy link
Contributor

See code review comments: https://codereview.chromium.org/48493002/

If a test approaches the preset timeout value report it, similarly to the longest running tests in the overall harness.

@iposva-google
Copy link
Contributor Author

cc @mkustermann.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg, Pkg-Unittest labels.

@srawlins
Copy link
Member

srawlins commented Oct 1, 2014

I'm interested in this. Let's get specific. How about:

* Warning is printed for a test if the test takes X% of timeout (timeout default is 2 minutes).

  • X is a variable of Configuration, defaulting to 0.8 (80%). A value of null means warning is never printed.
  • The durations of the slowest Y tests are always printed.
  • Y is a variable of Configuration, defaulting to 5.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/test#233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants