Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swarm has a lot of test suppressions #14523

Closed
mkustermann opened this issue Oct 28, 2013 · 8 comments
Closed

Swarm has a lot of test suppressions #14523

mkustermann opened this issue Oct 28, 2013 · 8 comments
Assignees
@rakudrama
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@mkustermann
Copy link
Member

The following tests seem to have started failing after running these tests in an iframe instead of a new browser window.

dart2js-safari:

samples/swarm/test/swarm_test (http://build.chromium.org/p/client.dart/builders/dart2js-safari-mac10.7-3-3-be/builds/1218/steps/dart2js-safari%20tests%20failures/logs/stdio)

html/websql_test/functional (http://build.chromium.org/p/client.dart/builders/dart2js-safari-mac10.7-2-3-be/builds/1164/steps/dart2js-safari%20tests%20failures/logs/stdio)

dart2js-chrome:

samples/swarm/test/swarm_test (build.chromium.org/p/client.dart/builders/dart2js-chrome-mac10.7-be/builds/900/steps/dart2js-chrome%20tests%20failures/logs/stdio)

@blois/efortuna:
Do these tests have the requirement that they run in a new window?
Are the failures legitimate?
@efortuna
Copy link
Contributor

Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot
Copy link

DartBot commented Sep 5, 2014

This comment was originally written by whesse@chromium.org

html/websql_test/functional has started passing after the iframe containing it comes from the same server as the containing page (the same port number). Maybe it was a cross-origin issue.

@alan-knight
Copy link
Contributor

WebSQL tests seem to be ok and is deprecated.

The swarm testing in general doesn't seem to be in great shape. Right now it fails for me on Chrome, passes on Dartium and Firefox, and passes on Safari, but only after putting alarming messages on the console. Swarm doesn't work well with current dev infrastructure, it's not a package, the README for running it is wrong, but Stephen doesn't want to change Swarm any more than necessary, and it's not a high priority.

Removed Type-Defect, Priority-Unassigned, Area-Library, Library-Html labels.
Added Type-CodeHealth, Priority-Low, Area-Samples labels.
Changed the title to: "Swarm has a lot of test suppressions".

@alan-knight
Copy link
Contributor

Set owner to @rakudrama.

@mkustermann mkustermann added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P3 A lower priority bug or feature request area-samples (deprecated) Deprecated: this label is no longer actively used. Triaged labels Jan 22, 2015
@rakudrama
Copy link
Member

We don't run swarm tests anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakudrama rakudrama

Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @rakudrama @efortuna @kasperl @alan-knight @mkustermann @DartBot