Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html/dromaeo_smoke_test uses postMessage which is also recognized by test_controller.js #14521

Open
mkustermann opened this issue Oct 28, 2013 · 1 comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mkustermann
Copy link
Member

The html/dromaeo_smoke_test test is posting data which is received by the test driver page. The driving page in return assumes that the test is finished and what it got is a DOM, so it'll post the DOM back to test.dart.

But what get's actually posted is not the DOM, but rather some json:

  FAILED: dart2js-safari release_ia32 html/dromaeo_smoke_test
  Expected: Pass
  Actual: RuntimeError
  CommandOutput[dart2js]:
  CommandOutput[safari]:

  stdout:
  {"command":"inited","data":{"nTests":1}}
 
  stderr:

http://build.chromium.org/p/client.dart/builders/dart2js-safari-mac10.7-1-3-be/builds/1215/steps/dart2js-safari%20tests%20failures/logs/stdio

Marking it as flaky for now.

To make the driver page more robust, we should introduce a special "protocol" and ignore messages posted which don't follow that "protocol".

The test could also be changed to not post data to the opener / driving window page.

@efortuna
Copy link
Contributor

Yep, but this is by design on the dromaeo end -- because we want to as closely replicate the behavior of the actual dromaeo test as possible.

@mkustermann mkustermann added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Oct 30, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants