Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JsonCodec.withReviver constructor to also take an toEncodable function. #14434

Open
lrhn opened this issue Oct 25, 2013 · 3 comments
Open

Change JsonCodec.withReviver constructor to also take an toEncodable function. #14434

lrhn opened this issue Oct 25, 2013 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. core-2 library-convert P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@lrhn
Copy link
Member

lrhn commented Oct 25, 2013

The current JsonCode.withReviver constructor allows constructing a JsonCodec with a different default reviver for the decoder.
Now that the encoder can also be parameterized with a function, the constructor should maybe be changed to .withDefaults that can take either or both of these functions.
@floitschG
Copy link
Contributor

Definitely.

Added Ready-to-implement, Accepted labels.

@lrhn
Copy link
Member Author

lrhn commented Jan 7, 2015

Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Low labels.

@lrhn lrhn added Type-Enhancement P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-convert labels Jan 7, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed accepted labels Feb 29, 2016
@lrhn lrhn added the core-m label Aug 11, 2017
@floitschG floitschG added core-2 and removed core-m labels Aug 28, 2017
@floitschG
Copy link
Contributor

This is fixed, but we should remove the withReviver constructor for Dart 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. core-2 library-convert P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @lrhn @floitschG @mit-mit