Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audiocontext_test fails on Safari #14354

Closed
jmesserly opened this issue Oct 23, 2013 · 10 comments
Closed

audiocontext_test fails on Safari #14354

jmesserly opened this issue Oct 23, 2013 · 10 comments
Assignees
@alan-knight
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P1 A high priority bug; for example, a single project is unusable or has many test failures type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Milestone
1.10

Comments

@jmesserly
Copy link

I'm not sure why this started failing recently

in the oscillatorTypes test, the .type field returns an integer instead of a String.
I disabled: audiocontext_test/functional, in the status file
@efortuna
Copy link
Contributor

This started failing with this CL:

 https://codereview.chromium.org//28973003

http://chromegw.corp.google.com/i/client.dart/builders/dart2js-safari-mac10.7-2-3-be/builds/970

cc @rmacnak-google.

@efortuna
Copy link
Contributor

Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@rmacnak-google
Copy link
Contributor

Removed the owner.

@alan-knight
Copy link
Contributor

The original problem is no longer valid. However, re-enabling this test reveals that our rename for Panner is not working on Safari, so this test file still fails.

Set owner to @alan-knight.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-CodeHealth, Priority-High labels.

@alan-knight
Copy link
Contributor

https://codereview.chromium.org/873803002/

Added Started label.

@kasperl
Copy link

kasperl commented Mar 20, 2015

Added this to the 1.10 milestone.

@alan-knight
Copy link
Contributor

This was fixed in r43149, I assume that means 1.9.

Added Fixed label.

@jmesserly jmesserly added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P1 A high priority bug; for example, a single project is unusable or has many test failures area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html Fixed labels Apr 17, 2015
@jmesserly jmesserly added this to the 1.10 milestone Apr 17, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alan-knight alan-knight

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P1 A high priority bug; for example, a single project is unusable or has many test failures type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
6 participants
@kevmoo @jmesserly @efortuna @kasperl @alan-knight @rmacnak-google