Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js strange type check failure #14352

Closed
jmesserly opened this issue Oct 23, 2013 · 1 comment
Closed

dart2js strange type check failure #14352

jmesserly opened this issue Oct 23, 2013 · 1 comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@jmesserly
Copy link

  1. in pkg/template_binding/test/custom_element_bindings_test.dart, revert this patch: https://codereview.chromium.org/33173004
  • AttributeMapWrapper _attributes;
  • AttributeMapWrapper<String, String> _attributes;
  1. run ./tools/test.py -m release -r drt --checked pkg/template_binding/test/custom_element_bindings
  2. test will fail with http://127.0.0.1:35051/root_build/generated_compilations/dart2js-checked/pkg_template_binding_test_custom_element_bindings_test/test.js:3819:
    Uncaught type 'AttributeMapWrapper' is not a subtype of type 'AttributeMapWrapper'

which is strange. IIRC, plain AttributeMapWrapper should mean AttributeMapWrapper<dynamic, dynamic> which is assignable to AttributeMapWrapper<String, String>

@peter-ahe-google
Copy link
Contributor

cc @johnniwinther.
cc @karlklose.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@jmesserly jmesserly added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

3 participants