Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check iterators #14178

Closed
stevemessick opened this issue Oct 17, 2013 · 9 comments
Closed

Check iterators #14178

stevemessick opened this issue Oct 17, 2013 · 9 comments
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

Username: kasperl

When we have code like this:

   MyClass m = ...;
   for (var x in m) {
     ...
   }

it would be useful to get a warning or a hint if m doesn't implement the 'iterator' getter. Not sure if this is covered by the spec, but it might be (in which case it should be a warning).
////////////////////////////////////////////////////////////////////////////////////
Editor: 0.1.2_r28706 (2013-10-16)
OS: Linux - i386 (3.2.5-gg1336)
JVM: 1.7.0-google-v5

projects: 1

open dart files: 11

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1933 / 684 / 147 MB
thread count: 32
index: 408792 relationships in 86532 keys in 297 sources

SDK installed: true
Dartium installed: false
@clayberg
Copy link

cc @bwilkerson.
Set owner to @jwren.
Removed Type-Defect label.
Added Type-Enhancement label.

@jwren
Copy link
Member

jwren commented Oct 17, 2013

Removed this from the M8 milestone.
Added this to the Later milestone.

@jwren
Copy link
Member

jwren commented Feb 7, 2014

cc: gbracha@google.com,

We do currently create a warning when the condition of an if-statement isn't a boolean.

cc @gbracha.

@bwilkerson
Copy link
Member

Added Analyzer-Hint label.

@gbracha
Copy link
Contributor

gbracha commented Apr 7, 2014

The spec does not allow for a warning. It could be a hint.

@jwren
Copy link
Member

jwren commented Apr 7, 2014

Correct. The issue is marked as a hint.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@stevemessick stevemessick added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@jwren jwren removed their assignment Oct 6, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

This is done as of: cb7aa02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kevmoo @srawlins @jwren @kasperl @gbracha @bwilkerson @stevemessick @clayberg