Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams article needs update to remove EventTransformStream #14148

Closed
kwalrath opened this issue Oct 16, 2013 · 8 comments
Closed

Streams article needs update to remove EventTransformStream #14148

kwalrath opened this issue Oct 16, 2013 · 8 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. docs-articles library-io type-documentation A request to add or improve documentation

Comments

@kwalrath
Copy link
Contributor

Due to EventTransformStream's removal, dartlang.org tests are failing. Could you please update the article and the tests? If the changes are straightforward, you can make them directly in github (https://github.com/dart-lang/dartlang.org/tree/master/src/site/articles/creating-streams). If not, you can either get your own dartlang.org git repo and make a CL, or give me the new code/words in whatever way is easiest for you.

You can view the article here:
https://www.dartlang.org/articles/creating-streams/

-k-

@kwalrath
Copy link
Contributor Author

I've removed the offending code from the article and tests, but it'd be good to update the article with new recommendations.

@kevmoo
Copy link
Member

kevmoo commented May 14, 2014

Removed Area-IO label.
Added Library-IO, Area-Library labels.

@kwalrath kwalrath added type-documentation A request to add or improve documentation Priority-Unassigned docs-articles library-io area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels May 14, 2014
@lrhn
Copy link
Member

lrhn commented Aug 20, 2015

Is this still relevant?

@kwalrath
Copy link
Contributor Author

I'm not sure. If the stream tutorial covers everything you need, we can retire this article. If it doesn't, we should talk about doc needs for streams.

cc @Sfshaza

@lrhn
Copy link
Member

lrhn commented Dec 8, 2015

I believe Kathy has a newer and better async streams tutorial at https://www.dartlang.org/docs/tutorials/streams/
@kwalrath : I think we can retire (mark as obsolete) the old one.

@lrhn lrhn closed this as completed Dec 8, 2015
@kwalrath
Copy link
Contributor Author

kwalrath commented Dec 8, 2015

The tutorial is about using streams, and the article is about creating streams. We removed the really obsolete sections that used EventTransformStream & StreamEventTransformer.

If you think that people don't need info on creating streams (or at least, not up-to-date info on that)—then we can mark the article as obsolete.

If you think it would help developers, we could add links to the source for libraries that have good examples of creating streams.

@lrhn
Copy link
Member

lrhn commented Dec 9, 2015

On Tue, Dec 8, 2015 at 7:44 PM, Kathy Walrath notifications@github.com
wrote:

The tutorial https://www.dartlang.org/docs/tutorials/streams/ is about
using streams, and the article
https://www.dartlang.org/articles/creating-streams/ is about creating
streams. We removed the really obsolete sections that used
EventTransformStream & StreamEventTransformer.

If you think that people don't need info on creating streams (or at least,
not up-to-date info on that)—then we can mark the article as obsolete.

Ack, true, there is a difference.

If you think it would help developers, we could add links to the source
for libraries that have good examples of creating streams.

Or I could rewrite the article to use async*. I should probably do that. :)

/L

Lasse R.H. Nielsen - lrn@google.com
'Faith without judgement merely degrades the spirit divine'
Google Denmark ApS - Frederiksborggade 20B, 1 sal - 1360 København K

  • Denmark - CVR nr. 28 86 69 84

@kwalrath
Copy link
Contributor Author

kwalrath commented Dec 9, 2015

Rewriting to use async* would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. docs-articles library-io type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

3 participants