Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Dartium Error with KeyEvent streams #14044

Closed
DartBot opened this issue Oct 12, 2013 · 6 comments
Closed

Internal Dartium Error with KeyEvent streams #14044

DartBot opened this issue Oct 12, 2013 · 6 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Oct 12, 2013

This issue was originally filed by chris....@gmail.com

To reproduce:
1.Create a KeyEvent stream and listen
2.Hit any key

Expect: the stream callback should be invoked (if it matches the key event type)

Actual: Internal Dartium Exception (undefined)

I am using the continuous build for linux: Dart VM version: 0.1.2.0_r28552 (Fri Oct 11 14:06:31 2013) on "linux_x64"

Sample test files attached. Also note that the tests in https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/tests/html/keyboard_event_test.dart pass, but if the page is left open and I manually type, I get Internal Dartium Exceptions.

Attachments:
key_event.html (172 Bytes)
main.dart (372 Bytes)
@kasperl
Copy link

kasperl commented Oct 14, 2013

Added Area-Dartium, Triaged labels.

@vsmenon
Copy link
Member

vsmenon commented Oct 14, 2013

chris.eee: We've had some recent changes in this code. Do you know if this worked properly before? Thanks!

cc @efortuna.

@efortuna
Copy link
Contributor

Set owner to @efortuna.
Added this to the Later milestone.

@DartBot
Copy link
Author

DartBot commented Oct 14, 2013

This comment was originally written by chri...@gmail.com

Define “worked”? :P

It used to be possible to dispatch keyboard events w/ $dom_keyIdentifier until ~2 months ago. It worked, but was extremely hacky and was not consistent across browers. It was removed in favor of this KeyEvent approach.

This report is a result of me trying the new KeyEvent interface from https://codereview.chromium.org/23455033/ (and subsequent fixes). It just made it into bleeding edge last week and, since I am extremely eager to have this functionality, I gave it a try w/ the continuous build.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@efortuna efortuna removed their assignment Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @matanlurey @efortuna @vsmenon @kasperl @DartBot