Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate resource loading issues on dartium #14011

Closed
mkustermann opened this issue Oct 11, 2013 · 6 comments
Closed

Investigate resource loading issues on dartium #14011

mkustermann opened this issue Oct 11, 2013 · 6 comments
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mkustermann
Copy link
Member

The none-drt tests on our dartium builders fail sometimes on windows with the following error message:

  FAILED: none-drt release_ia32 pkg/analyzer_experimental/test/generated/parser_test
  Expected: Pass
  Actual: RuntimeError
  CommandOutput[content_shell]:

  stdout:
  CONSOLE MESSAGE: line -1: Failed to load a file package:stack_trace/src/vm_trace.dart
  CONSOLE MESSAGE: line 172: FAIL
  CONSOLE MESSAGE: line -1: Failed to load a file package:path/path.dart
  CONSOLE MESSAGE: line 172: FAIL
  Content-Type: text/plain
  Running /D:/kustermann/dart/dart/pkg/analyzer_experimental/test/generated/parser_test.dart

  FAIL
  FAIL
  #EOF
  #EOF

Steps to reproduce:

$ mkdir dartium
$ cd dartium
dartium/ $ gclient config https://dart.googlecode.com/svn/branches/bleeding_edge/deps/dartium.deps
dartium/ $ gclient sync --revision=27863 --transitive --nohooks --verbose --nohooks
dartium/ $ gclient runhooks
dartium/ $ "c:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE\devenv.com" src\build\all.sln /Build Release /Project dartium_builder
  => Dartium is under dartium/src/build/Release/chrome.exe
  => ContentShell is under dartium/src/build/Release/content_shell.exe

dartium/ $ cd ..
$ mkdir dart
$ cd dart
dart/ $ gclient config http://dart.googlecode.com/svn/branches/bleeding_edge/deps/all.deps
dart/ $ gclient sync
dart/ $ gclient runhooks
dart/ $ python tools\build.py -mrelease create_sdk
dart/ $ python tools\test.py -mrelease -cnone -rdrt --drt=....\dartium\src\build\Release\content_shell.exe --write-debug-log pkg
  => Running this in a loop will result sometimes in "Fail to load a file ..." issue

After debugging we found out, that the resource loads are failing because a NetworkChange event is propagated through the chrome process (which probably makes us abort http requests).

For now we've fixed this issue, by only propagating NetworkChange events if they really happen (see https://codereview.chromium.org/25847003/).

We still need to investigate why an error occurs which makes us receive a "bogus event" on the NetworkChange handle we're listening on. The ERROR_OPERATION_ABORTED message given indicates "The I/O operation has been aborted because of either a thread exit or an application request." (according to msdn documentation).

This bug should stay open until we've found out the exact reason why the ERROR_OPERATION_ABORTED is sometimes reported on the handle.

@dartium-team: Could somebody take ownership of this?

@vsmenon
Copy link
Member

vsmenon commented Oct 11, 2013

Thanks, Martin. I don't expect we'll have cycles to get to this before M8, but I'm marking as Priority-High so that we revisit soon after.


Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-High label.

@lrhn
Copy link
Member

lrhn commented Jan 28, 2014

Could we set a new milestone on this?


Added Area-Dartium label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed Oldschool-Milestone-Later label.

@vsmenon
Copy link
Member

vsmenon commented Jul 15, 2014

Removed this from the 1.6 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

6 participants