Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawnUri_A01_t0* tests are timing out on Dartium #13992

Closed
vsmenon opened this issue Oct 10, 2013 · 4 comments
Closed

spawnUri_A01_t0* tests are timing out on Dartium #13992

vsmenon opened this issue Oct 10, 2013 · 4 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report library-async

Comments

@vsmenon
Copy link
Member

vsmenon commented Oct 10, 2013

These 5 tests (under co19) pass locally for me on drt, but time out occasionally (and frequently) on the Dartium bots with --runtime=dartium.

@ricowind
Copy link
Contributor

So there are multiple issues hiding here:
They don't actually really run under drt, it is just that the wrapping messed this up. Martin just landed a fix for this.
The real problem is that when we call spawnUri, the files are loaded relative to either the main dart script or relative to the html file (in our case, that does not really matter, since both of these are not located next to the file with the test)

I don't really see how spawnUri can be really useful in packages like this, they have no way of knowing what to relative load something from (as it is now, it will be wrong unless you hardcode some path in and assume that users restrict the location of the package relative to the main script).

Florian: Since you are changing this stuff, please let us know what you come up with.


cc @mkustermann.
cc @munificent.
Removed Priority-Unassigned, Area-Test labels.
Added Priority-Medium, Library-Async labels.

@anders-sandholm
Copy link
Contributor

Added Area-Library label.

@lrhn
Copy link
Member

lrhn commented May 8, 2014

Libraries cannot really use spawnUri with a relative URL because they have no control over the base URL used, and they don't have an easy way to access their own URL (you can get it using mirrors).

We should consider making a way for a library to find its own URL without going through mirrors. That will allow it to load files that are part of the same library using relative URLs.

@alan-knight
Copy link
Contributor

Added Duplicate label.
Marked as being merged into #15974.

@vsmenon vsmenon added Type-Defect library-async area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report labels Mar 6, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report library-async
Projects
None yet
Development

No branches or pull requests

5 participants