Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify dart:isolate tests to run on Dartium #13921

Closed
vsmenon opened this issue Oct 9, 2013 · 7 comments
Closed

Modify dart:isolate tests to run on Dartium #13921

vsmenon opened this issue Oct 9, 2013 · 7 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. core-a library-isolate needs-info We need additional information from the issue author (auto-closed after 14 days if no response) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@vsmenon
Copy link
Member

vsmenon commented Oct 9, 2013

We no longer support spawnFunction from the DOM isolate on Dartium. Instead, spawnUri must be used to create a background isolate (which cannot access dart:html). spawnFunction may be used from background isolates.

The following tests now fail on Dartium. We should consider either:
(a) Modifying the tests to use spawnUri
(b) Running them automatically in a background isolate (in the test framework?)

browser/compute_this_script_browser_stream_test: Fail
browser/compute_this_script_browser_test: Fail
count_stream_test: Fail
count_test: Fail
cross_isolate_message_test: Fail
global_error_handler2_test: Fail
global_error_handler_stream2_test: Fail
global_error_handler_stream_test: Fail
global_error_handler_test: Fail
illegal_msg_stream_test: Fail
illegal_msg_test: Fail
isolate_complex_messages_stream_test: Fail
isolate_complex_messages_test: Fail
mandel_isolate_stream_test: Fail
mandel_isolate_test: Fail
message2_test: Fail
message_stream2_test: Fail
message_stream_test: Fail
message_test: Fail
mint_maker_test: Fail
nested_spawn2_test: Fail
nested_spawn_stream_test: Fail
nested_spawn_test: Fail
request_reply_test: Fail
spawn_function_custom_class_test: Fail
spawn_function_test: Fail
stacktrace_message_test: Fail
unresolved_ports_test: Fail
@vsmenon
Copy link
Member Author

vsmenon commented Oct 9, 2013

Actually, this breaks many more tests in the unittest package and elsewhere. See:

https://codereview.chromium.org/26616002/

cc @ricowind.

@ricowind
Copy link
Contributor

ricowind commented Oct 9, 2013

Special casing the running of certain tests in the test controller because the tests are wrongly written seems like a bad idea to me. Is anything preventing us from simply fixing up the tests?

cc @mkustermann.

@ricowind
Copy link
Contributor

So Florian actually have a cl pending:
https://codereview.chromium.org/20703003/
Where he fixes up the isolate spawn functionality so that the tests can catch these spawnFunction errors and report something reasonable (we sort of already can, we can pass in a error callback)
I added a comment here:
https://codereview.chromium.org/26397003/
asking why we don't throw an exception instead of reporting a problem (which will go to the console).
I think we need to figure that out
Assigning back to Vijay to get input on this

Set owner to @vsmenon.
Added NeedsInfo label.

@lrhn
Copy link
Member

lrhn commented May 5, 2014

Added Library-Isolate label.

@lrhn
Copy link
Member

lrhn commented Oct 29, 2014

Issue #14626 has been merged into this issue.

cc @vsmenon.

@lrhn
Copy link
Member

lrhn commented Oct 29, 2014

Marked this as being blocked by #17649.

@vsmenon vsmenon added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-isolate needs-info We need additional information from the issue author (auto-closed after 14 days if no response) labels Oct 29, 2014
@vsmenon vsmenon self-assigned this Oct 29, 2014
@whesse whesse mentioned this issue Jun 3, 2015
Closed
@a-siva a-siva mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@vsmenon vsmenon removed their assignment Jun 30, 2017
@lrhn lrhn added the core-a label Aug 11, 2017
@bkonyi
Copy link
Contributor

bkonyi commented Jun 18, 2018

Dartium is dead (woohoo!). Closing.

@bkonyi bkonyi closed this as completed Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. core-a library-isolate needs-info We need additional information from the issue author (auto-closed after 14 days if no response) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @vsmenon @lrhn @ricowind @bkonyi