Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine how / when to create Dartium application snapshots #13903

Closed
vsmenon opened this issue Oct 8, 2013 · 3 comments
Closed

Determine how / when to create Dartium application snapshots #13903

vsmenon opened this issue Oct 8, 2013 · 3 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@vsmenon
Copy link
Member

vsmenon commented Oct 8, 2013

We currently eagerly create an application snapshot for a page when a script is loaded.

With multiple script tags mapping to the same isolate, we now throw away the old snapshot (if one existed) and create a new one from scratch.

The snapshot caching code is bitrotted, but we do also use these snapshots to support spawn isolate APIs.

Perhaps we should only create them on demand?
@dgrove
Copy link
Contributor

dgrove commented May 8, 2014

Set owner to @vsmenon.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@vsmenon vsmenon self-assigned this Aug 4, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@vsmenon vsmenon removed their assignment Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @matanlurey @dgrove @vsmenon @kasperl