Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: combine assignments (shorter code) #13763

Closed
stevemessick opened this issue Oct 2, 2013 · 5 comments
Closed

dart2js: combine assignments (shorter code) #13763

stevemessick opened this issue Oct 2, 2013 · 5 comments
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@stevemessick
Copy link
Contributor

[user feedback]

I have this repeating pattern in dart2js output:

W.ew7.$isa=true

W.Koa.$isrg=true

W.Koa.$isa=true

W.ipe.$isrg=true
...
some hundred lines...
Couldn't they be combined to:

W.ew7.$isa=W.Koa.$isrg=W.Koa.$isa=W.ipe.$isrg=true

That would save around 5kb in my situation.

////////////////////////////////////////////////////////////////////////////////////
Editor: 0.7.5_r27776 (2013-09-23)
OS: Windows 8 - amd64 (6.2)
JVM: 1.7.0_21

projects: 1

open dart files: 1

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 889 / 447 / 70 MB
thread count: 28
index: 421861 relationships in 79695 keys in 678 sources

SDK installed: true
Dartium installed: true
@kasperl
Copy link

kasperl commented Oct 3, 2013

Removed the owner.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Oct 3, 2013

Changed the title to: "dart2js: combine assignments (shorter code)".

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@stevemessick stevemessick added Type-Enhancement P3 A lower priority bug or feature request web-dart2js labels Aug 4, 2014
@rakudrama
Copy link
Member

Obsolete. We no longer generate this code, rather we use properties.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @rakudrama @kasperl @stevemessick