Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart_EvaluateExpr quietly truncates invalid expressions #13723

Closed
jacob314 opened this issue Oct 1, 2013 · 2 comments
Closed

Dart_EvaluateExpr quietly truncates invalid expressions #13723

jacob314 opened this issue Oct 1, 2013 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jacob314
Copy link
Member

jacob314 commented Oct 1, 2013

In Dartium we have to wrap expression in parentheses to ensure only valid Dart expressions are allowed. Otherwise the DartVM will quietly ignore trailing Dart statements resulting in user confusion when part of the invalid expression they entered is ignored.
I will attach a CL with a simple test case reproducing this issue.

This isn't overly high priority as I have a pretty clean workaround (adding parens) but it would be nice to fix.

Example problem expressions

int x

"foo"; bar
@jacob314
Copy link
Member Author

jacob314 commented Oct 2, 2013

Here is a repro. All 3 test clauses listed here should pass but only "var x" currently behaves as expected.
https://codereview.chromium.org/25620003

@sethladd
Copy link
Contributor

sethladd commented Oct 2, 2013

Added Triaged label.

@jacob314 jacob314 added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Oct 2, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@iposva-google iposva-google added the closed-obsolete Closed as the reported issue is no longer relevant label May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sethladd @kevmoo @jacob314 @iposva-google