Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests failing on none-dartium #13719

Closed
mkustermann opened this issue Oct 1, 2013 · 9 comments
Closed

Tests failing on none-dartium #13719

mkustermann opened this issue Oct 1, 2013 · 9 comments
Assignees
@a-siva
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mkustermann
Copy link
Member

I'm in the process of getting dartium testing up and running. I'll mark failing tests on the "none-dartium" configuration with this issue number.

All the upcoming failures need to be triaged.
@blois
Copy link
Contributor

blois commented Oct 4, 2013

Possibly missing the --enable-experimental-web-platform-features flag?

@a-siva
Copy link
Contributor

a-siva commented Oct 31, 2013

Is there a way to pass test specific options when running tests on dartium.

For instance thw following tests fail because the tests rely on that fact that
the option '--throw_on_javascript_int_overflow' will be set

javascript_int_overflow_literal_test/01: Fail # Issue #13719: Please triage this failure.
javascript_int_overflow_test: Fail # Issue #13719: Please triage this failure.

The test has the line
// VMOptions=--throw_on_javascript_int_overflow
int it.

@mkustermann
Copy link
Member Author

No support for this yet (only checked/unchecked mode). Florian opened Issue #14651 for this.

@ricowind
Copy link
Contributor

There is still a bunch of these that has not been triaged, Vijay/Siva do you want to look into this

cc @vsmenon.
Set owner to @a-siva.

@a-siva
Copy link
Contributor

a-siva commented Nov 26, 2013

Will take a look.

@a-siva
Copy link
Contributor

a-siva commented Mar 17, 2014

Issue #17525 has been merged into this issue.

cc @jacob314.
cc @whesse.
cc @iposva-google.

@whesse
Copy link
Member

whesse commented Mar 17, 2014

Issue #17525 has been merged into this issue.

1 similar comment
@a-siva
Copy link
Contributor

a-siva commented Mar 17, 2014

Issue #17525 has been merged into this issue.

@mkustermann mkustermann added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Mar 17, 2014
@a-siva a-siva mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@dgrove
Copy link
Contributor

dgrove commented Apr 25, 2018

Dartium has been removed.

@dgrove dgrove closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @dgrove @blois @whesse @ricowind @mkustermann @a-siva