Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js fails on large integer constants #13683

Closed
johnniwinther opened this issue Sep 30, 2013 · 8 comments
Closed

dart2js fails on large integer constants #13683

johnniwinther opened this issue Sep 30, 2013 · 8 comments
Assignees
@johnniwinther
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@johnniwinther
Copy link
Member

dart2js fails on large integer constants. These tests use 1<<128:

co19/LibTest/isolate/IsolateSink/add_A01_t01
co19/LibTest/isolate/SendPort/send_A02_t01
@peter-ahe-google
Copy link
Contributor

Sounds like a dupe of issue #1533 (dart2js doesn't implement numbers correctly).

Added Duplicate label.
Marked as being merged into #1533.

@johnniwinther
Copy link
Member Author

Reopening for dart2dart which should be able to generate code for these.

Removed Area-Dart2JS label.
Added Area-Dart2Dart, Triaged labels.
Marked as being merged into #.

@kasperl
Copy link

kasperl commented Sep 30, 2013

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@floitschG
Copy link
Contributor

co19/LibTest/isolate/IsolateSink/add_A01_t01 does not exist anymore, and dart2dart passes co19/LibTest/isolate/SendPort/send_A02_t01 now.

Added AssumedStale label.

@johnniwinther
Copy link
Member Author

co19/LibTest/isolate/SendPort/send_A02_t01 does not contain 1 &lt;&lt; 128 (anymore).

const c = 1 &lt;&lt; 128; is still a problem for dart2dart.

Added Triaged label.

@johnniwinther
Copy link
Member Author

Set owner to @johnniwinther.

@johnniwinther johnniwinther self-assigned this Nov 24, 2014
@sethladd sethladd added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jul 10, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sethladd @kevmoo @kasperl @peter-ahe-google @floitschG @johnniwinther