Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: libraries should not use IterableMixinWorkaround #13648

Closed
lrhn opened this issue Sep 27, 2013 · 6 comments
Closed

dart2js: libraries should not use IterableMixinWorkaround #13648

lrhn opened this issue Sep 27, 2013 · 6 comments
Labels
web-dart2js

Comments

@lrhn
Copy link
Member

lrhn commented Sep 27, 2013

Dart2js currently uses IterableMixinWorkaround to implement some methods of JSArray.
IterableMixinWorkaround is duplicating code and not always giving the correct result when type parameters are involved, so it should be replaced by extending ListBase or mixin in ListMixin.

Simply changing the current code to extend ListBase makes interceptors for lists not work correctly.
@lrhn
Copy link
Member Author

lrhn commented Sep 27, 2013

Marked this as blocking #13646.

@kasperl
Copy link

kasperl commented Sep 27, 2013

Added this to the M7 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.
Changed the title to: "dart2js: libraries should not use IterableMixinWorkaround".

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@lrhn
Copy link
Member Author

lrhn commented Dec 17, 2013

cc @floitschG.

@lrhn
Copy link
Member Author

lrhn commented May 23, 2014

I am considering duplicating the functions from ListBase on JSArray unless there is a way to make the class both be an Interceptor and a ListBase.
I assume you will need to use ListBase, not ListMixin, since the List class has a const constructor, which doesn't interact well with mixins.

Removed this from the M8 milestone.

@rakudrama
Copy link
Member

IterableMixinWorkaround removed at https://code.google.com/p/dart/source/detail?r=44006

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakudrama @kasperl @lrhn