Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM internal List classes should extend ListBase or mixin ListMixin instead of using IterableMixinWorkaround. #13647

Closed
lrhn opened this issue Sep 27, 2013 · 7 comments
Closed

VM internal List classes should extend ListBase or mixin ListMixin instead of using IterableMixinWorkaround. #13647

lrhn opened this issue Sep 27, 2013 · 7 comments
Assignees
@iposva-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@lrhn
Copy link
Member

lrhn commented Sep 27, 2013

There should be no uses of IterableMixinWorkaround in the libraries.

It is a source of code duplication and its behavior isn't correct in cases where the result needs the generic type of the calling class.
@lrhn
Copy link
Member Author

lrhn commented Sep 27, 2013

I can rewrite the Dart libraries to use ListMixin or ListBase, but it runs into problems with the number of expected type parameters.

@lrhn
Copy link
Member Author

lrhn commented Sep 27, 2013

Marked this as blocking #13646.

@iposva-google
Copy link
Contributor

You cannot easily change the class hierarchy for VM internal classes as they need to match both in the C++ and Dart sides. We will remove the use of the IterableMixinWorkaround in one way or another.

Removed Priority-Unassigned label.
Added Priority-High, Accepted labels.

@iposva-google
Copy link
Contributor

Set owner to @iposva-google.

@iposva-google
Copy link
Contributor

Added Started label.

@iposva-google
Copy link
Contributor

Removed Priority-High label.
Added Priority-Medium label.

@fsc8000
Copy link
Contributor

fsc8000 commented Feb 24, 2015

Fixed. With r42066, r42061 and r43379 IterableMixinWorkaround is not used in the VM internal classes anymore.

Added Fixed label.

@lrhn lrhn added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Feb 24, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iposva-google iposva-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsc8000 @lrhn @iposva-google