Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IterableMixinWorkaround class. #13646

Closed
lrhn opened this issue Sep 27, 2013 · 4 comments
Closed

Remove IterableMixinWorkaround class. #13646

lrhn opened this issue Sep 27, 2013 · 4 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-internal P3 A lower priority bug or feature request

Comments

@lrhn
Copy link
Member

lrhn commented Sep 27, 2013

The IterableMixinWorkaround class was a tempory hack to allow reuse of code before we had mixins.
The classes that use it should instead mixin IterableMixin or ListMixin, or possibly one of the hidden UnmodifiableListMixin and NonGrowingListMixin.

The code in IterableMixinWorkaround duplicates the code in IterableMixin, and it does so without having the type parameters available, so the return values loses type parameterization.
@lrhn
Copy link
Member Author

lrhn commented Sep 27, 2013

Marked this as being blocked by #13647, #13648.

@lrhn
Copy link
Member Author

lrhn commented May 5, 2014

Added Library-Internal label.

@sethladd
Copy link
Contributor

Removed Priority-Unassigned label.
Added Priority-Low label.

@rakudrama
Copy link
Member

IterableMixinWorkaround removed at https://code.google.com/p/dart/source/detail?r=44006

Added Fixed label.

@lrhn lrhn added Type-Defect P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-internal labels Feb 25, 2015
@lrhn lrhn mentioned this issue Jun 3, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-internal P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sethladd @rakudrama @lrhn