Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Invoke* and Lookup* functions in the embedding API #13643

Closed
DartBot opened this issue Sep 27, 2013 · 3 comments
Closed

Reuse Invoke* and Lookup* functions in the embedding API #13643

DartBot opened this issue Sep 27, 2013 · 3 comments
Assignees
Labels
area-vm closed-obsolete Closed as the reported issue is no longer relevant library-mirrors needs-info We need additional information from the issue author (auto-closed after 14 days if no response) type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@DartBot
Copy link

DartBot commented Sep 27, 2013

This issue was originally filed by mlippautz@google.com


Reuse Invoke* and Lookup* functions in the embedding API

@rmacnak-google
Copy link
Contributor

Added Accepted label.

@DartBot DartBot added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable Priority-Unassigned area-vm library-mirrors labels Sep 27, 2013
@zanderso zanderso added the needs-info We need additional information from the issue author (auto-closed after 14 days if no response) label Jan 5, 2017
@zanderso
Copy link
Member

zanderso commented Jan 5, 2017

Maybe fill this out with some more information so that it's more clear what needs to be done here.

@rmacnak-google rmacnak-google added the closed-obsolete Closed as the reported issue is no longer relevant label Jan 9, 2017
@rmacnak-google
Copy link
Contributor

rmacnak-google commented Jan 9, 2017

IIRC this was related to the implementation of ClosureMirror.findInContext, which has since been removed. Marking as stale.

dart-bot pushed a commit that referenced this issue Aug 9, 2018
Refactor the implementation of 'invoke' for sharing between the embedding API, mirrors, and the VM service. The fixes various issues in the embedding API:
 - Dart_Invoke, Dart_GetField and Dart_SetField now generate the same NoSuchMethodErrors as dart:mirrors and ordinary Dart code.
 - Dart_GetField and Dart_SetField now accept a null receiver.
 - Dart_GetField now handles closurization.
 - Dart_Invoke now handles calls through function-typed getters.
In mirrors, it also changes:
 - LibraryMirror.invoke/getField/setField now see members in the export namespace, not just local declarations. I.e., invocation with a LibraryMirror behaves the same ways as invocation against a library prefix in ordinary Dart code.

Bug: #11870
Bug: #13643
Bug: #29893
Bug: #33417
Bug: #34006
Change-Id: I913e8eef16943a3e86eda55c8d122819e41ad7cc
Reviewed-on: https://dart-review.googlesource.com/67302
Reviewed-by: Siva Annamalai <asiva@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm closed-obsolete Closed as the reported issue is no longer relevant library-mirrors needs-info We need additional information from the issue author (auto-closed after 14 days if no response) type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

4 participants