Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart2js and dart2dart wrongly report compile-time error for non conflicting constructor and setter names #13639

Closed
crelier opened this issue Sep 26, 2013 · 10 comments
Closed

Dart2js and dart2dart wrongly report compile-time error for non conflicting constructor and setter names #13639

crelier opened this issue Sep 26, 2013 · 10 comments
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@crelier
Copy link
Contributor

crelier commented Sep 26, 2013

Spec:

The name of a setter is obtained by appending the string `=' to the identifier given in its signature.
Hence, a setter name can never conflict with, override or be overridden by a getter or method.

bad_constructor_test/05 wrongly reports a compile-time error
@kasperl
Copy link

kasperl commented Sep 27, 2013

Added this to the M7 milestone.
Removed Priority-Unassigned label.
Added Priority-Low label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@crelier crelier added Type-Defect P3 A lower priority bug or feature request web-dart2js labels Aug 4, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@johnniwinther
Copy link
Member

There is also a conflict between methods and setter in setter4_test

@terrylucas
Copy link
Contributor

terrylucas commented Oct 11, 2017 •
edited

Dart 2.0 (Analyzer) now reports compile-time error.

@lrhn
Copy link
Member

lrhn commented Oct 11, 2017

I'm not aware of any changes in this regard for Dart 2.0, so are we sure it's correct for the analyzer to report a compile-time error?

@lrhn lrhn reopened this Oct 11, 2017
@sigmundch
Copy link
Member

this appears now to be working correctly - bad_constructor_test is not mentioned in any .status file at at this time.

@sigmundch
Copy link
Member

(except for the Dart1 implementation of dart2js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @sigmundch @terrylucas @kasperl @lrhn @crelier @johnniwinther