Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect warnings are issued for overriding methods in dart2js #13487

Closed
anders-sandholm opened this issue Sep 22, 2013 · 6 comments
Closed

Incorrect warnings are issued for overriding methods in dart2js #13487

anders-sandholm opened this issue Sep 22, 2013 · 6 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@anders-sandholm
Copy link
Contributor

co19 test fails

Language/07_Classes/1_Instance_Methods_A03_t06.dart

It expects no warnings because function types of overriding methods are subtypes of corresponding types of overriden methods according to 15.5 Function Types.

Namely

 dynamic f1(Super x, [Sub a, Super b])
is subtype of
int f1(Super x, Super y, [Super a])

and

int f2(Super x, [Sub a, Super b, Whatever c])
is subtype of
int f2(Super x, Super y, [Super a])

dart2js version of issue
@anders-sandholm
Copy link
Contributor Author

dart2js version of issue #13344

@kasperl
Copy link

kasperl commented Sep 23, 2013

Added this to the M7 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@anders-sandholm anders-sandholm added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @kasperl @anders-sandholm