Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: support groups #13476

Closed
jmesserly opened this issue Sep 21, 2013 · 4 comments
Closed

Logger: support groups #13476

jmesserly opened this issue Sep 21, 2013 · 4 comments
Labels
area-pkg type-enhancement A request for a change that isn't a bug

Comments

@jmesserly
Copy link

window.console has this feature, and it's really useful.

https://developer.mozilla.org/en-US/docs/Web/API/console#Using_groups_in_the_console

... Polymer uses this for some of its logging. I'm not sure whether to try and match Polymer and use console logging, or try and use Dart's Logger API. One benefit to Logger is I don't need to expose any public APIs related to logging.

@sigmundch
Copy link
Member

Yeah, I discovered group recently and it is super nice.

It would be good to discuss what's the best way to add support for this. Today Logger has no logic about how the logs are printed out. Instead, we let you attach custom onRecord listeners that you can use to print things out to the console.

One idea, for example, would be to match groups with hierarchical names. In particular, today you can use logger names like: "a", "a.b", "a.c", and then you can selectively print what's under "a", or "a.b" or "a.c". We could create a custom onRecord listener that uses the nesting level of the logger to group messages. Thoughts?

@anders-sandholm
Copy link
Contributor

Removed Library-Logging label.
Added Pkg-Logging label.

@jmesserly
Copy link
Author

moved to dart-lang/logging#4

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/logging#15.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants