New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconcile query/queryAll with new method being spec'd #13357
Comments
The joys of renaming stuff. We'll most likely have to name this something different, causing confusion. Unless we deprecate & rename query and queryAll right now. |
Yeah, my preference would be to rename Dart query/queryAll, and introduce the newer friendlier methods as query/queryAll. Else we are stuck forever with a confusing divergence from the web platform. Rollout of the breaking change is tricky. I think most code will prefer to remain unchanged (using the shorter names) even if they are a tad slower. It is a strange king of breaking change because for the most part it isn't breaking, just may select more things. But it could break some code. |
There may also be some changes to matches coming- currently the spec & dart's name is matches, but all the browsers implement it as matchesSelector (prefixed). There's a good deal of rumbling about this changing as well, but it's much less clear what the answer is for us. |
Dropping to High, since this isn't blocking us now. Still needs to addressed for M8. Removed Priority-Critical label. |
Set owner to @efortuna. |
The first phase of this has gone in here: moving the next phase to Milestone:Later as we will not implement the next phase until a subsequent milestone. Removed this from the M8 milestone. |
Removed Area-HTML label. |
Removed this from the Later milestone. |
Added this to the 1.6 milestone. |
Removed Oldschool-Milestone-Later label. |
lowering priority to medium as the part needing immediate attention has been addressed (adding queryAll vs querySelectorAll). The next phase is changing the behavior of queryAll to the new behavior instead of the deprecated version. Removed this from the 1.6 milestone. |
I feel like we're in a good place here ... we fixed our name, now awaiting new one to be more widely implemented |
Saw this today on public-webapps. The plan for the DOM is to use the query/queryAll names for functions that match using "relative selectors".
See here:
http://dom.spec.whatwg.org/#dom-parentnode-query
Note that it does not have the same behavior as querySelector/querySelectorAll.
Offhand it looks polyfillable. However, we will probably want to have the simpler querySelector/querySelectorAll for performance reasons.
The text was updated successfully, but these errors were encountered: