Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use command line flags instead of ENV variables to control VM settings in Dartium #13300

Closed
vsmenon opened this issue Sep 13, 2013 · 12 comments
Closed
Assignees

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 13, 2013

Instead of DART_FLAGS or DART_PACKAGE_ROOT, we should use command line flags.

We'll need the editor to change appropriately.

@vsmenon
Copy link
Member Author

vsmenon commented Sep 13, 2013

See related bug:

https://code.google.com/p/dart/issues/detail?id=3092

It makes sense to expose some flags (e.g., checked mode) via HTML but keep other internal ones here.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@iposva-google
Copy link
Contributor

We should use the same mechanism as V8 to pass flags.

Marking as high because we do not want to change this in the future.


Set owner to @a-siva.
Removed Priority-Unassigned label.
Added Priority-High, Accepted labels.

@a-siva
Copy link
Contributor

a-siva commented Oct 30, 2013

V8 uses --js-flags='...' to pass in flags but I was told this is not something people use in general and it is more of a debugging/profiling aid for v8 developers.

A command line flag does not solve all the issues as we want some of the options to be set on an Isolate specific fashion. Considering that we are still discussing the various possibilities of passing options to an Isolate we should change the milestone of this to post M8.

@a-siva
Copy link
Contributor

a-siva commented Oct 30, 2013

Issue #3092 has been merged into this issue.


cc @iposva-google.
cc @dgrove.
cc @anders-sandholm.

@vsmenon
Copy link
Member Author

vsmenon commented Nov 14, 2013

Removed this from the M8 milestone.
Added this to the 1.1 milestone.

@vsmenon
Copy link
Member Author

vsmenon commented Feb 27, 2014

Removed this from the 1.1 milestone.
Added this to the 1.3 milestone.

@vsmenon
Copy link
Member Author

vsmenon commented Jun 4, 2014

Removed this from the 1.3 milestone.
Added this to the 1.6 milestone.

@vsmenon
Copy link
Member Author

vsmenon commented Aug 6, 2014

Removed this from the 1.6 milestone.
Added this to the 1.7 milestone.

@dgrove
Copy link
Contributor

dgrove commented Sep 23, 2014

Is this happening for 1.7 ?

@a-siva
Copy link
Contributor

a-siva commented Sep 23, 2014

Removed this from the 1.7 milestone.
Removed Priority-High label.
Added Priority-Unassigned label.

@a-siva
Copy link
Contributor

a-siva commented Oct 16, 2015

Will not fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants