Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Non-determinism in html code gen script #13286

Closed
vsmenon opened this issue Sep 12, 2013 · 7 comments
Closed

[next] Non-determinism in html code gen script #13286

vsmenon opened this issue Sep 12, 2013 · 7 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 12, 2013

In html_dartium.dart, running go.sh sometimes reorders these overloads. It should be deterministic.

@@ -26121,13 +26122,13 @­@ class Url extends NativeFieldWrapperClass1 {
     if ((blob_OR_source_OR_stream is Blob || blob_OR_source_OR_stream == null)) {
       return _createObjectURL_1(blob_OR_source_OR_stream);
     }

  • if ((blob_OR_source_OR_stream is MediaStream || blob_OR_source_OR_stream == null)) {
  • if ((blob_OR_source_OR_stream is MediaSource || blob_OR_source_OR_stream == null)) {
           return _createObjectURL_2(blob_OR_source_OR_stream);
         }
  • if ((blob_OR_source_OR_stream is MediaSource || blob_OR_source_OR_stream == null)) {
  • if ((blob_OR_source_OR_stream is _WebKitMediaSource || blob_OR_source_OR_stream == null)) {
           return _createObjectURL_3(blob_OR_source_OR_stream);
         }
  • if ((blob_OR_source_OR_stream is _WebKitMediaSource || blob_OR_source_OR_stream == null)) {
  • if ((blob_OR_source_OR_stream is MediaStream || blob_OR_source_OR_stream == null)) {
           return _createObjectURL_4(blob_OR_source_OR_stream);
         }
@efortuna
Copy link
Contributor

efortuna commented Oct 2, 2013

Added this to the Later milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

Removed Priority-Unassigned label.
Added Priority-Low label.
Changed the title to: "[next] Non-determinism in html code gen script".

@vsmenon vsmenon added Type-Defect P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 23, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@natebosch
Copy link
Member

@vsmenon - I'm not familiar with these tools - do they still exist? Was this strictly related to dartium?

@vsmenon
Copy link
Member Author

vsmenon commented Sep 5, 2018

It's the tools that generate dart:html from IDL files. This seems obsolete. @terrylucas - please reopen if I'm mistaken.

@vsmenon vsmenon closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

6 participants