Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: initialize dispatch records on isolate startup where possible - preemptive patching #13218

Closed
rakudrama opened this issue Sep 10, 2013 · 7 comments
Closed

dart2js: initialize dispatch records on isolate startup where possible - preemptive patching #13218

rakudrama opened this issue Sep 10, 2013 · 7 comments
Assignees
@rakudrama
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@rakudrama
Copy link
Member

The dispatch property is currently initialized with the appropriate dispatch record on demand.

In V8 there would be fewer map transitions if it was initialized in advance for constructors available from [window].

This would also fix some problems:

  1. Issue Incorrect interceptors on patched elements in Firefox #13190, where installing the dispatch record would side-step a Firefox bug
  2. Uint8ClampedList no longer inherits from Uint8List but some browsers do inplement with inheritance. Preemptive patching would avoid the need for the ugly hack in https://chromiumcodereview.appspot.com/23464052
@rakudrama
Copy link
Member Author

Marked this as blocking #13190.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@rakudrama
Copy link
Member Author

Marked this as blocking #13758.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@rakudrama rakudrama self-assigned this Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@rakudrama
Copy link
Member Author

Fixed. initNativeDispatchContinue () loops over known tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakudrama rakudrama

Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @rakudrama @kasperl