Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback to use when dart2js encounters code that doesn't match spec #13168

Closed
sethladd opened this issue Sep 8, 2013 · 5 comments
Closed
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@sethladd
Copy link
Contributor

sethladd commented Sep 8, 2013

It would be extremely helpful to developers if dart2js can provide feedback when it encounters code that the compiler knows (or, is fairly confident of) will not work when compiled to JavaScript.

I am aware of two cases (at least one that has been encounted by a customer)

(1 is double) // true in dart2js, false in vm
(1.0 is int) // true in dart2js, false in vm

Thanks for the consideration.

@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 23, 2013

Removed this from the M7 milestone.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Sep 30, 2013

Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@sigmundch sigmundch added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants