Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittest: expectAsync should include reason #13105

Closed
jmesserly opened this issue Sep 5, 2013 · 5 comments
Closed

unittest: expectAsync should include reason #13105

jmesserly opened this issue Sep 5, 2013 · 5 comments
Labels
area-pkg type-enhancement A request for a change that isn't a bug

Comments

@jmesserly
Copy link

adding "reason:" to expect is a nice way to include a human readable message to "expect". Would be nice if "expectAsync" methods also had this functionality.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Added Pkg-Unittest label.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg label.

@srawlins
Copy link
Member

srawlins commented Oct 7, 2014

I've got this going at https://codereview.chromium.org/638433003


cc @munificent.
Set owner to @srawlins.
Added Started label.

@srawlins
Copy link
Member

srawlins commented Oct 7, 2014

Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/test#227.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants