Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to WheelEvent constructor rather than document.createEvent #12958

Closed
peter-ahe-google opened this issue Aug 31, 2013 · 10 comments
Closed
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@peter-ahe-google
Copy link
Contributor

After rolling Dartium forward in r26947, html/wheelevent_test started failing on dart2js.

@jacob314
Copy link
Member

jacob314 commented Sep 2, 2013

Looks like we need to start using the true WheelEvent constructor on Chrome when running dart2js.


Set owner to @blois.

@efortuna
Copy link
Contributor

Added this to the Later milestone.

@ricowind
Copy link
Contributor

After updating to chrome31 this is also failing on chrome win/mac

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

On Chrome we call initWebKitWheelEvent which has been removed. It looks like Firefox also supports WheelEvent now, but the code for this is a messy bunch of platform-specific cases which need to be checked carefully.


Removed the owner.
Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.
Changed the title to: "Switch to WheelEvent constructor rather than document.createEvent".

@alan-knight
Copy link
Contributor

I seem to be fixing this in the context of another bug.


Set owner to @alan-knight.

@peter-ahe-google peter-ahe-google added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Apr 24, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@natebosch
Copy link
Member

@alan-knight - did this end up getting fixed?

@alan-knight
Copy link
Contributor

It looks like it to me. At least I see this for WheelEvent in html_dart2js.

return JS('WheelEvent', 'new WheelEvent(#, #)', type,
        convertDartToNative_Dictionary(options));
``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

8 participants