Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find common way of handling checked mode tests for the Vm and dart2js #12927

Closed
sgjesse opened this issue Aug 30, 2013 · 2 comments
Closed

Find common way of handling checked mode tests for the Vm and dart2js #12927

sgjesse opened this issue Aug 30, 2013 · 2 comments
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sgjesse
Copy link
Contributor

sgjesse commented Aug 30, 2013

Some tests use the VMOptions comments like this

// VMOptions=--checked

or

// VMOptions=--enable_type_checks

It is used to make tests which test for static type warnings to pass in both checked and unchecked mode (basically always running then in checked mode on the VM).

For dart2js all these tests are added to the status file with status "Fail, OK".

This should be handled in a common way, and possibly in a way where all these tests are not taking up space in the status files.
@ricowind
Copy link
Contributor

Removed Area-Test label.
Added Area-Infrastructure label.

@sgjesse sgjesse added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Nov 26, 2013
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey
Copy link
Contributor

Checked mode is a goner

@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @matanlurey @sgjesse @ricowind