Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test language/list_literal4_test fails on dart2js #12890

Closed
sgjesse opened this issue Aug 29, 2013 · 6 comments
Closed

Test language/list_literal4_test fails on dart2js #12890

sgjesse opened this issue Aug 29, 2013 · 6 comments
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@sgjesse
Copy link
Contributor

sgjesse commented Aug 29, 2013

FAILED: dart2js-d8 debug_ia32 language/list_literal4_test
Expected: pass
Actual: fail
CommandOutput[dart2js]:

stdout:
tests/language/list_literal4_test.dart:14:24: Warning: "int" is not assignable to "String".
      var m = <String>[0, 1]; // 0 is not a String.
                       ^
tests/language/list_literal4_test.dart:14:27: Warning: "int" is not assignable to "String".
      var m = <String>[0, 1]; // 0 is not a String.
                          ^
tests/language/list_literal4_test.dart:25:19: Warning: "String" is not assignable to "T".
      var m = <T>["a", "b"]; // "b" is not an int.
                  ^^^
tests/language/list_literal4_test.dart:25:24: Warning: "String" is not assignable to "T".
      var m = <T>["a", "b"]; // "b" is not an int.
                       ^^^
tests/language/list_literal4_test.dart:30:19: Warning: "int" is not assignable to "T".
      var m = <T>[0, 1]; // OK.
                  ^
tests/language/list_literal4_test.dart:30:22: Warning: "int" is not assignable to "T".
      var m = <T>[0, 1]; // OK.
                     ^
tests/language/list_literal4_test.dart:35:19: Warning: "int" is not assignable to "T".
      var m = <T>[0, 1];
                  ^
tests/language/list_literal4_test.dart:35:22: Warning: "int" is not assignable to "T".
      var m = <T>[0, 1];
                     ^
tests/language/list_literal4_test.dart:47:19: Warning: "int" is not assignable to "T".
      var m = <T>[0, 1]; // OK. Tested above.
                  ^
tests/language/list_literal4_test.dart:47:22: Warning: "int" is not assignable to "T".
      var m = <T>[0, 1]; // OK. Tested above.
                     ^

CommandOutput[d8]:

stdout:
/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:981: Illegal argument(s): 0
        throw exception;
              ^
Error
    at wrapException (/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:349:13)
    at JSArray.$indexSet (/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:140:15)
    at $.$indexSet$a (/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:1147:39)
    at ListLiteral4Test.test$0 (/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:971:9)
    at main (/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:949:53)
    at /usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:1228:7
    at Isolate.$isolateProperties.$currentScript (/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:1197:5)
    at /usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:1215:3
    at /usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js:1412:3

Command[dart2js]: sdk/bin/dart2js --allow-mock-compilation --categories=all --package-root=out/DebugIA32/packages/ /usr/local/prj/dart/git/dart/tests/language/list_literal4_test.dart --out=/usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js
Took 0:00:15.780000

Command[d8]: /usr/local/prj/dart/git/dart/third_party/d8/linux/d8 /usr/local/prj/dart/git/dart/out/DebugIA32/generated_tests/dart2js-d8/tests_language_list_literal4_test/out.js
Took 0:00:00.026000

Short reproduction command (experimental):
    python tools/test.py -t480 -rd8 -cdart2js language/list_literal4_test

It also seems like dart2js gives more warnings that the analyzer.

$ dartanalyzer --package-root=out/ReleaseIA32/packages/ tests/language/list_literal4_test.dart
Analyzing tests/language/list_literal4_test.dart...
[warning] The element type 'int' cannot be assigned to the list type 'String' (/usr/local/prj/dart/git/dart/tests/language/list_literal4_test.dart, line 14, col 24)
[warning] The element type 'int' cannot be assigned to the list type 'String' (/usr/local/prj/dart/git/dart/tests/language/list_literal4_test.dart, line 14, col 27)
2 warnings found.

This test should be re-written to a multi-test.

@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 30, 2013

Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants