Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some language tests are using VMOptions only available in standalone VM #12796

Closed
mkustermann opened this issue Aug 27, 2013 · 7 comments
Closed

Some language tests are using VMOptions only available in standalone VM #12796

mkustermann opened this issue Aug 27, 2013 · 7 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mkustermann
Copy link
Member

The following tests use the '--compile_all' standalone VM flag, which is not available in dartium. They are failing, because the VM doesn't compile all code:

tests/language/external_test.dart
tests/language/get_set_syntax_test.dart
tests/language/syntax_test.dart

We can either

  • introduce the flag in dartium as well via DART_FLAGS
  • or make these tests as Skip/SkipByDesign in the status file.

For now, I'll mark the failing tests as "Fail, OK".
@iposva-google
Copy link
Contributor

The tests have been fixed with r26723. It might still be a good idea to add support for --compile_all to DRT.

@mkustermann
Copy link
Member Author

cc @vsmenon.
cc @a-siva.
Removed Area-Test label.
Added Area-Dartium label.

@a-siva
Copy link
Contributor

a-siva commented Sep 18, 2013

Added this to the Later milestone.

@a-siva
Copy link
Contributor

a-siva commented Oct 23, 2013

Issue #14321 has been merged into this issue.

cc @ricowind.
cc @mkustermann.
cc @iposva-google.

@rmacnak-google
Copy link
Contributor

Issue #14321 has been merged into this issue.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@mkustermann mkustermann mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @matanlurey @kasperl @iposva-google @mkustermann @rmacnak-google @a-siva