New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart2js_extra/deferred/deferred_function_test is flaky on IE #12635
Comments
Pete: could you take a look at this. It sounds like the "load" event hack doesn't work. Cheers, Set owner to @blois. |
Pete: Some extra info, since I spend most of the morning on this. If I run the test in either selenium or the new browser controller I see this. You can also easily reproduce this by running the http server and load it in IE. Cheers, |
The test just timed out. Added 'Timeout' to the status file. |
Looking into it- there is an IE bug with the current script detection that I've been looking at (see https://codereview.chromium.org/23021012/). Beyond that, what I'm seeing is that the isolate appears to be getting loaded synchronously in IE9 (not IE10) when the request for the JS file gets a 304 from the server. Basically the test does something like: And putting a console.log in the generated JS file for the library, I'm seeing it print before the 'just after load' when the lib is not dirty- so the library method is available before the test thinks it should be. |
https://codereview.chromium.org/23523003/ cc @blois. |
Fixed in r26903. |
Added Fixed label. |
Didn't work, hopefully this will work: https://codereview.chromium.org/23678006/ Added Started label. |
Second attempt to fix: r26971. Added Fixed label. |
Still not fixed. Added Triaged label. |
Added this to the M7 milestone. |
Removed Priority-Unassigned label. |
Set owner to @sigurdm. |
Now the tests fail instead of timing out. |
Marked as flaky also: language/deferred_constraints_test/type_annotation_generic1
|
Removed this from the 1.6 milestone. |
Removed Oldschool-Milestone-1.6 label. |
Marking as such for now until we figure out why it is failing
This seems to be related to how we get the thisScript
The text was updated successfully, but these errors were encountered: