Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js_extra/deferred/deferred_function_test is flaky on IE #12635

Closed
ricowind opened this issue Aug 22, 2013 · 19 comments
Closed

dart2js_extra/deferred/deferred_function_test is flaky on IE #12635

ricowind opened this issue Aug 22, 2013 · 19 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@ricowind
Copy link
Contributor

Marking as such for now until we figure out why it is failing

This seems to be related to how we get the thisScript

@peter-ahe-google
Copy link
Contributor

Pete: could you take a look at this. It sounds like the "load" event hack doesn't work.

Cheers,
Peter


Set owner to @blois.

@ricowind
Copy link
Contributor Author

Pete: Some extra info, since I spend most of the morning on this.

If I run the test in either selenium or the new browser controller I see this. You can also easily reproduce this by running the http server and load it in IE.
I occasionally (often on the first load) get a missing file being requested from the http server, normally either root_dart/pkg/browser/lib/part.js or root_dart/pkg/unittest/lib/part.js (this is suppose to be requested from the generated tests directory inside the specific test dir).
Additionally, when we actually get the scripts, we sometimes see it passing, and sometimes we see a failing on refreshing the browser window.

Cheers,
Rico

@floitschG
Copy link
Contributor

The test just timed out. Added 'Timeout' to the status file.

@blois
Copy link
Contributor

blois commented Aug 22, 2013

Looking into it- there is an IE bug with the current script detection that I've been looking at (see https://codereview.chromium.org/23021012/).

Beyond that, what I'm seeing is that the isolate appears to be getting loaded synchronously in IE9 (not IE10) when the request for the JS file gets a 304 from the server.

Basically the test does something like:
  lazy.load().then(...)
  window.console.log('just after load');
  Expect.throws(() { foo('a'); }, isNoSuchMethodError);

And putting a console.log in the generated JS file for the library, I'm seeing it print before the 'just after load' when the lib is not dirty- so the library method is available before the test thinks it should be.

@peter-ahe-google
Copy link
Contributor

https://codereview.chromium.org/23523003/


cc @blois.
Set owner to @peter-ahe-google.
Added Started label.

@peter-ahe-google
Copy link
Contributor

Fixed in r26903.

@peter-ahe-google
Copy link
Contributor

Added Fixed label.

@peter-ahe-google
Copy link
Contributor

Didn't work, hopefully this will work: https://codereview.chromium.org/23678006/


Added Started label.

@peter-ahe-google
Copy link
Contributor

Second attempt to fix: r26971.


Added Fixed label.

@peter-ahe-google
Copy link
Contributor

Still not fixed.


Added Triaged label.

@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 30, 2013

Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@peter-ahe-google
Copy link
Contributor

Set owner to @sigurdm.

@sigurdm
Copy link
Contributor

sigurdm commented Feb 14, 2014

Now the tests fail instead of timing out.

@sigurdm
Copy link
Contributor

sigurdm commented Mar 7, 2014

Marked as flaky also:

language/deferred_constraints_test/type_annotation_generic1
language/deferred_constraints_test/type_annotation_generic4
language/deferred_constraints_test/type_annotation2

  • seems to be same issue.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the M8 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed triaged labels Feb 29, 2016
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed Type-Defect labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

8 participants